From d9fa502cab2dd3d6a3e4ffab61c6ae1859d3bd03 Mon Sep 17 00:00:00 2001 From: printempw Date: Sun, 11 Feb 2018 23:38:10 +0800 Subject: [PATCH] expose properties instead of methods on `MouseControl` --- src/viewer.js | 24 ++++++++++++++++++------ types/viewer.d.ts | 7 +++---- 2 files changed, 21 insertions(+), 10 deletions(-) diff --git a/src/viewer.js b/src/viewer.js index 14e9047..660db0e 100644 --- a/src/viewer.js +++ b/src/viewer.js @@ -240,16 +240,28 @@ class MouseControl { this.orbitControls.update(); } - togglePan(value) { - this.orbitControls.enablePan = (typeof value === "boolean") ? value : !this.orbitControls.enablePan; + get rotation() { + return this.orbitControls.enableRotate; } - toggleZoom(value) { - this.orbitControls.enableZoom = (typeof value === "boolean") ? value : !this.orbitControls.enableZoom; + set rotation(value) { + this.orbitControls.enableRotate = value; } - toggleRotate(value) { - this.orbitControls.enableRotate = (typeof value === "boolean") ? value : !this.orbitControls.enableRotate; + get zoom() { + return this.orbitControls.enableZoom; + } + + set zoom(value) { + this.orbitControls.enableZoom = value; + } + + get pan() { + return this.orbitControls.enablePan; + } + + set pan(value) { + this.orbitControls.enablePan = value; } dispose() { diff --git a/types/viewer.d.ts b/types/viewer.d.ts index 3d7c66e..e6e64d0 100644 --- a/types/viewer.d.ts +++ b/types/viewer.d.ts @@ -35,13 +35,12 @@ export class SkinViewer { } export class MouseControl { - public enableMouseControl: boolean; + public pan: boolean; + public zoom: boolean; + public rotation: boolean; public readonly skinViewer: SkinViewer; constructor(skinViewer: SkinViewer); - public togglePan(): void; - public toggleZoom(): void; - public toggleRotate(): void; public dispose(): void; }