From ac7ab8ab3cf6c1f12051fc841ac249060e7354a3 Mon Sep 17 00:00:00 2001
From: alexbegt <traincrazyb@aol.com>
Date: Tue, 14 May 2019 19:51:38 -0400
Subject: [PATCH] Create the EntityItem only when it's needed. Closes #178

---
 .../chest/TileEntityIronChestRenderer.java         | 14 +++++++++-----
 .../shulker/TileEntityIronShulkerBoxRenderer.java  | 14 +++++++++-----
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/src/main/java/cpw/mods/ironchest/client/renderer/chest/TileEntityIronChestRenderer.java b/src/main/java/cpw/mods/ironchest/client/renderer/chest/TileEntityIronChestRenderer.java
index f4a2059..952dc51 100755
--- a/src/main/java/cpw/mods/ironchest/client/renderer/chest/TileEntityIronChestRenderer.java
+++ b/src/main/java/cpw/mods/ironchest/client/renderer/chest/TileEntityIronChestRenderer.java
@@ -49,7 +49,7 @@ public class TileEntityIronChestRenderer extends TileEntitySpecialRenderer<TileE
             { 0.5F, 0.32F, 0.5F } };
     //@formatter:on
 
-    private static EntityItem customitem = new EntityItem(null);
+    private static EntityItem customItem;
 
     private static float halfPI = (float) (Math.PI / 2D);
 
@@ -183,8 +183,12 @@ public class TileEntityIronChestRenderer extends TileEntitySpecialRenderer<TileE
             GlStateManager.pushMatrix();
             GlStateManager.translate((float) x, (float) y, (float) z);
 
-            customitem.setWorld(this.getWorld());
-            customitem.hoverStart = 0F;
+            if (customItem == null)
+            {
+                customItem = new EntityItem(this.getWorld());
+            }
+
+            customItem.hoverStart = 0F;
 
             for (ItemStack item : te.getTopItems())
             {
@@ -209,7 +213,7 @@ public class TileEntityIronChestRenderer extends TileEntitySpecialRenderer<TileE
                 GlStateManager.rotate(timeD, 0F, 1F, 0F);
                 GlStateManager.scale(blockScale, blockScale, blockScale);
 
-                customitem.setItem(item);
+                customItem.setItem(item);
 
                 if (this.itemRenderer == null)
                 {
@@ -235,7 +239,7 @@ public class TileEntityIronChestRenderer extends TileEntitySpecialRenderer<TileE
                     };
                 }
 
-                this.itemRenderer.doRender(customitem, 0D, 0D, 0D, 0F, partialTicks);
+                this.itemRenderer.doRender(customItem, 0D, 0D, 0D, 0F, partialTicks);
 
                 GlStateManager.popMatrix();
             }
diff --git a/src/main/java/cpw/mods/ironchest/client/renderer/shulker/TileEntityIronShulkerBoxRenderer.java b/src/main/java/cpw/mods/ironchest/client/renderer/shulker/TileEntityIronShulkerBoxRenderer.java
index c04e278..6e29cae 100644
--- a/src/main/java/cpw/mods/ironchest/client/renderer/shulker/TileEntityIronShulkerBoxRenderer.java
+++ b/src/main/java/cpw/mods/ironchest/client/renderer/shulker/TileEntityIronShulkerBoxRenderer.java
@@ -40,7 +40,7 @@ public class TileEntityIronShulkerBoxRenderer extends TileEntitySpecialRenderer<
     private static float[][] shifts = { { 0.3F, 0.45F, 0.3F }, { 0.7F, 0.45F, 0.3F }, { 0.3F, 0.45F, 0.7F }, { 0.7F, 0.45F, 0.7F }, { 0.3F, 0.1F, 0.3F }, { 0.7F, 0.1F, 0.3F }, { 0.3F, 0.1F, 0.7F }, { 0.7F, 0.1F, 0.7F }, { 0.5F, 0.32F, 0.5F } };
     //@formatter:on
 
-    private static EntityItem customitem = new EntityItem(null);
+    private static EntityItem customItem;
 
     public TileEntityIronShulkerBoxRenderer()
     {
@@ -174,8 +174,12 @@ public class TileEntityIronShulkerBoxRenderer extends TileEntitySpecialRenderer<
             GlStateManager.pushMatrix();
             GlStateManager.translate((float) x, (float) y, (float) z);
 
-            customitem.setWorld(this.getWorld());
-            customitem.hoverStart = 0F;
+            if (customItem == null)
+            {
+                customItem = new EntityItem(this.getWorld());
+            }
+
+            customItem.hoverStart = 0F;
 
             for (ItemStack item : te.getTopItems())
             {
@@ -200,7 +204,7 @@ public class TileEntityIronShulkerBoxRenderer extends TileEntitySpecialRenderer<
                 GlStateManager.rotate(timeD, 0F, 1F, 0F);
                 GlStateManager.scale(blockScale, blockScale, blockScale);
 
-                customitem.setItem(item);
+                customItem.setItem(item);
 
                 if (this.itemRenderer == null)
                 {
@@ -226,7 +230,7 @@ public class TileEntityIronShulkerBoxRenderer extends TileEntitySpecialRenderer<
                     };
                 }
 
-                this.itemRenderer.doRender(customitem, 0D, 0D, 0D, 0F, partialTicks);
+                this.itemRenderer.doRender(customItem, 0D, 0D, 0D, 0F, partialTicks);
 
                 GlStateManager.popMatrix();
             }