Ubujira
/
ironbarrels
2
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't send the entire NBT tag to the client (#133) 

The only extra bit of NBT the client needs here is facing. If we send
everything, then the client will know about the loot table when there is one,
which will result in this crash:

java.lang.NullPointerException: Rendering screen
	at net.minecraft.tileentity.TileEntityLockableLoot.fillWithLoot(TileEntityLockableLoot.java:59)
	at cpw.mods.ironchest.common.tileentity.chest.TileEntityIronChest.getStackInSlot(TileEntityIronChest.java:138)
	at net.minecraft.inventory.Slot.getStack(Slot.java:81)
	at net.minecraft.client.gui.inventory.GuiContainer.drawSlot(GuiContainer.java:234)
	at net.minecraft.client.gui.inventory.GuiContainer.drawScreen(GuiContainer.java:116)
	at cpw.mods.ironchest.client.gui.chest.GUIChest.drawScreen(GUIChest.java:100)
	at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:368)
	at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1177)
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1207)
	at net.minecraft.client.Minecraft.run(Minecraft.java:441)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:25)
This commit is contained in:
Joseph C. Sible 2018-04-09 21:12:13 -04:00 committed by Alexander (alexbegt)
parent 612cf234d9
commit 5cdce170c7
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/cpw/mods/ironchest/common/tileentity/chest/TileEntityIronChest.java
View File

@ -593,7 +593,9 @@ public class TileEntityIronChest extends TileEntityLockableLoot implements ITick
@Override @Override
public NBTTagCompound getUpdateTag() public NBTTagCompound getUpdateTag()
{ {
return this.writeToNBT(new NBTTagCompound()); NBTTagCompound compound = super.getUpdateTag();
compound.setByte("facing", (byte) this.facing.ordinal());
return compound;
} }
@Override @Override

4
src/main/java/cpw/mods/ironchest/common/tileentity/shulker/TileEntityIronShulkerBox.java
View File

@ -673,7 +673,9 @@ public class TileEntityIronShulkerBox extends TileEntityLockableLoot implements
@Override @Override
public NBTTagCompound getUpdateTag() public NBTTagCompound getUpdateTag()
{ {
return this.writeToNBT(new NBTTagCompound()); NBTTagCompound compound = super.getUpdateTag();
compound.setByte("facing", (byte) this.facing.ordinal());
return compound;
} }
@Override @Override