Simplified block icon assignment

src/main/java/cpw/mods/ironchest/BlockIronChest.java

@@ -33,6 +33,9 @@ import cpw.mods.fml.relauncher.Side;
 import cpw.mods.fml.relauncher.SideOnly;
 
 public class BlockIronChest extends BlockContainer {
+	@SideOnly(Side.CLIENT)
+    public static IIcon icon[] = new IIcon[IronChestType.values().length];
+
     public BlockIronChest()
     {
         super(Material.iron);
@@ -68,14 +71,22 @@ public class BlockIronChest extends BlockContainer {
 
     @Override
     @SideOnly(Side.CLIENT)
-    public IIcon getIcon(int i, int j)
+    public void registerBlockIcons(IIconRegister r)
     {
-        if (j < IronChestType.values().length)
+    	for (IronChestType type : IronChestType.values())
     	{
-            IronChestType type = IronChestType.values()[j];
+    		if (type.isValidForCreativeMode())
-            return type.getIcon(i);
+    		{
+    			icon[type.ordinal()] = r.registerIcon("ironchest:" + type.name().toLowerCase());
     		}
-        return null;
+    	}
+    }
+
+    @Override
+    @SideOnly(Side.CLIENT)
+    public IIcon getIcon(int side, int meta)
+    {
+    	return icon[meta];
     }
 
     @Override
@@ -238,16 +249,6 @@ public class BlockIronChest extends BlockContainer {
         return 0;
     }
 
-    @Override
-    @SideOnly(Side.CLIENT)
-    public void registerBlockIcons(IIconRegister par1IconRegister)
-    {
-        for (IronChestType typ: IronChestType.values())
-        {
-            typ.makeIcons(par1IconRegister);
-        }
-    }
-
     @Override
     public ForgeDirection[] getValidRotations(World worldObj, int x, int y, int z)
     {

src/main/java/cpw/mods/ironchest/IronChestType.java

@@ -4,17 +4,13 @@ import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
-import net.minecraft.client.renderer.texture.IIconRegister;
 import net.minecraft.init.Blocks;
 import net.minecraft.init.Items;
 import net.minecraft.item.Item;
 import net.minecraft.item.ItemStack;
 import net.minecraft.nbt.NBTTagByte;
-import net.minecraft.util.IIcon;
 import net.minecraftforge.oredict.ShapedOreRecipe;
 import cpw.mods.fml.common.registry.GameRegistry;
-import cpw.mods.fml.relauncher.Side;
-import cpw.mods.fml.relauncher.SideOnly;
 
 public enum IronChestType {
     IRON(54, 9, true, "Iron Chest", "ironchest.png", 0, Arrays.asList("ingotIron", "ingotRefinedIron"), TileEntityIronChest.class, "mmmmPmmmm", "mGmG3GmGm"),
@@ -204,32 +200,6 @@ public enum IronChestType {
         return this == OBSIDIAN;
     }
 
-    @SideOnly(Side.CLIENT)
-    private IIcon[] icons;
-
-    @SideOnly(Side.CLIENT)
-    public void makeIcons(IIconRegister par1IconRegister)
-    {
-        if (isValidForCreativeMode())
-        {
-            icons = new IIcon[3];
-            int i = 0;
-            for (String s : sideNames)
-            {
-                icons[i++] = par1IconRegister.registerIcon(String.format("ironchest:%s_%s",name().toLowerCase(),s));
-            }
-        }
-    }
-
-    @SideOnly(Side.CLIENT)
-    public IIcon getIcon(int side)
-    {
-        return icons[sideMapping[side]];
-    }
-
-    private static String[] sideNames = { "top", "front", "side" };
-    private static int[] sideMapping = { 0, 0, 2, 1, 2, 2, 2 };
-
     public boolean acceptsStack(ItemStack itemstack)
     {
         return itemFilter == null || itemstack == null || itemstack.getItem() == itemFilter;